Page MenuHomePhabricator

manifest: move matches method to be outside the interface

Authored by durin42 on Feb 5 2020, 5:34 PM.



In order to adequately smoke out any legacy consumers of the method, we rename
it to _matches so it's clear that it's class-private. To my amazement, all
consumers of this method really only wanted matching filenames, not a full
filtered manifest.

Diff Detail

rHG Mercurial
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Feb 5 2020, 5:34 PM
martinvonz requested changes to this revision.Feb 7 2020, 5:08 PM
martinvonz added a subscriber: martinvonz.
martinvonz added inline comments.

This now checks match.always() recursively for every tree manifest. Seems wasteful, but maybe not noticeable? Could you test (or just revert that part of the patch)?

This revision now requires changes to proceed.Feb 7 2020, 5:08 PM
durin42 updated this revision to Diff 20101.Feb 10 2020, 7:49 PM
pulkit accepted this revision.Feb 10 2020, 9:33 PM
This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.