This is an archive of the discontinued Mercurial Phabricator instance.

Differential D813

builddeb: remove leading "hg_" to make the Debian pkg version number valid
ClosedPublic

Authored by matvore on Sep 25 2017, 3:17 PM.

Details

Reviewers
quark
Group Reviewers
Restricted Project
Commits
rFBHGX45d4727d8a85: builddeb: remove leading "hg_" to make the Debian pkg version number valid

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

matvore created this revision.Sep 25 2017, 3:17 PM
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 25 2017, 3:17 PM
durin42 added a subscriber: durin42.Sep 25 2017, 3:32 PM

Oh, I see what's happened: the latest tag in hg-experimental is hg_4.3.1, presumably marking when it was tested or something. Prior to that no tags had been made since 2014, so we were just getting the 0.3.1 version number.

Ideally hg-experimental would have a version number other than the hg version number. What do Facebook people think?

simonfar added subscribers: quark, simonfar.Sep 25 2017, 3:44 PM

Internally, we don't have versioned releases - we build frequently (automation), and tend to take @ of upstream hg and our extensions when we build. There has been discussion internally (@quark should recall it) about doing a "release" whenever there's a matching Mercurial release coming out, so that people trying to use upstream Mercurial releases can use the nearest tested extensions from us.

quark added a comment.EditedSep 25 2017, 3:57 PM
In D813#13555, @durin42 wrote:

Oh, I see what's happened: the latest tag in hg-experimental is hg_4.3.1, presumably marking when it was tested or something. Prior to that no tags had been made since 2014, so we were just getting the 0.3.1 version number.

This is to make it easier to find the matched hg-experimental version with installed hg. There were several informal requests about that.

Ideally hg-experimental would have a version number other than the hg version number. What do Facebook people think?

If we don't have to support (branch and fix) old versions, that seems okay. Is it intended to be used just in debian packaging?

quark accepted this revision.Sep 25 2017, 4:00 PM

Pushed. Thanks!

This revision is now accepted and ready to land.Sep 25 2017, 4:00 PM
Closed by commit rFBHGX45d4727d8a85: builddeb: remove leading "hg_" to make the Debian pkg version number valid (authored by Matt DeVore <matvore@google.com>). · Explain WhySep 25 2017, 4:04 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mcontrib/builddeb (4 lines)

Diff 2068

contrib/builddeb

#!/bin/sh -e #!/bin/sh -e
# #
# Build a remotefilelog debian package from the current repo # Build a remotefilelog debian package from the current repo
if [ ! -d .hg ]; then if [ ! -d .hg ]; then
echo 'You are not at the repository root!' 1>&2 echo 'You are not at the repository root!' 1>&2
exit 1 exit 1
fi fi
cp -r contrib/debian debian cp -r contrib/debian debian
version=$(hg log -r . -T'{latesttag}+{latesttagdistance}-{node|short}') version=$(hg log -r . -T'{latesttag}+{latesttagdistance}-{node|short}')
# Remove "hg_" from start of $version so it starts with a digit, which makes it
# a valid version string.
version=${version/#hg_/}
control=debian/control control=debian/control
changelog=debian/changelog changelog=debian/changelog
# This looks like sed -i, but sed -i behaves just differently enough # This looks like sed -i, but sed -i behaves just differently enough
# between BSD and GNU sed that I gave up and did the dumb thing. # between BSD and GNU sed that I gave up and did the dumb thing.
sed "s/__VERSION__/$version/" < $changelog > $changelog.tmp sed "s/__VERSION__/$version/" < $changelog > $changelog.tmp
date=$(date --rfc-2822) date=$(date --rfc-2822)
sed "s/__DATE__/$date/" < $changelog.tmp > $changelog sed "s/__DATE__/$date/" < $changelog.tmp > $changelog
rm $changelog.tmp rm $changelog.tmp