This is an archive of the discontinued Mercurial Phabricator instance.

hgext/remotefilelog/shallowbundle.py
62	Since this is a keyword argument, this seems safer to pass it to the superclass as a keyword argument too. This will avoid sneaky issue if more argument are added.

This revision now requires changes to proceed.Feb 24 2020, 10:40 AM

pulkit marked an inline comment as done.Feb 24 2020, 1:02 PM

I just mean to use changelog=changelog in the super call... but this actually looks more robust.

This revision was not accepted when it landed; it landed in state Needs Review.

This revision was automatically updated to reflect the committed changes.

This was meant for stable branch, can we graft it to stable before the upcoming minor release? (cc: @durin42)

Is there a chance to get this fix in an upcoming minor release?

This is released as part of 5.3.1

Revision Contents
Changeset List

			Path	Packages
M			hgext/remotefilelog/shallowbundle.py (4 lines)

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	20258		Feb 19 2020, 3:26 AM	★	★
Diff 2	20287		Feb 24 2020, 1:00 PM	★	★
Diff 3	20306	rHG3cd79f55c1d771a2d04a61a357a99026a6bb9fbe	Feb 19 2020, 3:09 AM	★	★

	linknode = lookup(curr)			linknode = lookup(curr)
	for c in self.nodechunk(rlog, curr, prev, linknode):			for c in self.nodechunk(rlog, curr, prev, linknode):
	yield c			yield c

	yield self.close()			yield self.close()


	class shallowcg1packer(changegroup.cgpacker):			class shallowcg1packer(changegroup.cgpacker):
	def generate(self, commonrevs, clnodes, fastpathlinkrev, source):			def generate(self, commonrevs, clnodes, fastpathlinkrev, source, **kwargs):
	if shallowutil.isenabled(self._repo):			if shallowutil.isenabled(self._repo):
	fastpathlinkrev = False			fastpathlinkrev = False

	return super(shallowcg1packer, self).generate(			return super(shallowcg1packer, self).generate(
	commonrevs, clnodes, fastpathlinkrev, source			commonrevs, clnodes, fastpathlinkrev, source, **kwargs
				marmouteUnsubmitted Done Since this is a keyword argument, this seems safer to pass it to the superclass as a keyword argument too. This will avoid sneaky issue if more argument are added. marmoute: Since this is a keyword argument, this seems safer to pass it to the superclass as a keyword…
	)			)

	def group(self, nodelist, rlog, lookup, units=None, reorder=None):			def group(self, nodelist, rlog, lookup, units=None, reorder=None):
	return shallowgroup(			return shallowgroup(
	shallowcg1packer, self, nodelist, rlog, lookup, units=units			shallowcg1packer, self, nodelist, rlog, lookup, units=units
	)			)

	def generatefiles(self, changedfiles, *args):			def generatefiles(self, changedfiles, *args):