This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8178

heptapod-ci: also run tests for chg on python 2
ClosedPublic

Authored by marmoute on Feb 28 2020, 8:25 AM.

Details

Reviewers
Alphare
pulkit
Group Reviewers
hg-reviewers
Commits
rHGaa568b6c6a10: heptapod-ci: also run tests for chg on python 2
Summary

I am not aware of any regular effort to run test with chg. So let's at least do it
here.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Feb 28 2020, 8:25 AM
pulkit added a subscriber: pulkit.Feb 28 2020, 8:52 AM

Any reason why py3-chg is not included?

marmoute abandoned this revision.Feb 28 2020, 9:09 AM

how did this go on phabricator… (probably runing phabsend with the wrong hash)

marmoute added a comment.Feb 28 2020, 9:09 AM

abandonning this for now. I mostly wanted to see a run on heptapod (spoiler warning about 20 test are broken)

pulkit retitled this revision from heptapod-ci: also run some test for chg to heptapod-ci: also run tests for chg on python 2.Apr 2 2020, 11:57 AM
pulkit edited the summary of this revision. (Show Details)
pulkit updated this revision to Diff 20967.
marmoute added a comment.Apr 2 2020, 12:18 PM

Is this targetted for stable or default ? having it on stable would be nice.

pulkit added a comment.Apr 2 2020, 12:26 PM
In D8178#124930, @marmoute wrote:

Is this targetted for stable or default ? having it on stable would be nice.

Since all the fixes are on default branch, I am targeting it for default. Also default will be merged in stable after couple of weeks for release candidate, so we will have it in stable soon.

marmoute added a comment.Apr 2 2020, 12:59 PM

Can we get the fix grafted on the stable branches. There are people using chg in production that would need them.

pulkit added a comment.Apr 3 2020, 5:23 AM
In D8178#124932, @marmoute wrote:

Can we get the fix grafted on the stable branches. There are people using chg in production that would need them.

I don't have a strong opinion here because I feel fixes are minor.

pulkit added a comment.Apr 13 2020, 9:57 AM

Gentle review ping. Since, we are going to cut a RC this week, let's push this to default. Also for reviewers, the patch is still authored by @marmoute, I just rebased and updated after my chg fixes got in.

marmoute added a comment.Apr 15 2020, 2:27 PM

I wanted to make it accepted, but apparently I am flag as owner…

So this looks good to me. As followup we could have the same for pure and rust (probably starting with manual triggering to avoid CI load explosion).

What's the latest of having this for python3 ? it would be nice to have chg well covered there too.

marmoute added a comment.Apr 22 2020, 12:14 PM

Gentle ping, it would be nice to have this on stable.

Alphare accepted this revision.May 7 2020, 12:49 PM
pulkit accepted this revision.Jun 9 2020, 4:44 AM
This revision is now accepted and ready to land.Jun 9 2020, 4:44 AM
marmoute added a commit: rHGaa568b6c6a10: heptapod-ci: also run tests for chg on python 2.Jun 9 2020, 6:09 AM
Closed by commit rHGaa568b6c6a10: heptapod-ci: also run tests for chg on python 2 (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mcontrib/heptapod-ci.yml (6 lines)

Diff 21577

contrib/heptapod-ci.yml

test-py3-rust: test-py3-rust:
<<: *runtests <<: *runtests
variables: variables:
HGWITHRUSTEXT: cpython HGWITHRUSTEXT: cpython
RUNTEST_ARGS: "--rust --blacklist /tmp/check-tests.txt" RUNTEST_ARGS: "--rust --blacklist /tmp/check-tests.txt"
PYTHON: python3 PYTHON: python3
TEST_HGMODULEPOLICY: "rust+c" TEST_HGMODULEPOLICY: "rust+c"
test-py2-chg:
<<: *runtests
variables:
RUNTEST_ARGS: "--blacklist /tmp/check-tests.txt --chg"
TEST_HGMODULEPOLICY: "c"