This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8211

rust-pathauditor: actually split Windows shortname aliases at `~`
ClosedPublic

Authored by Alphare on Mar 4 2020, 9:45 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGe63b4a1f2271: rust-pathauditor: actually split Windows shortname aliases at `~`
Summary

Right now, splitting with a max of 1 parts is useless.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Revision Contents
Changeset List

Diff 20446

rust/hg-core/src/utils/path_auditor.rs

|| parts.iter().any(|c| c == b"..") || parts.iter().any(|c| c == b"..")
{ {
return Err(HgPathError::InsideDotHg(path.to_owned())); return Err(HgPathError::InsideDotHg(path.to_owned()));
} }
// Windows shortname aliases // Windows shortname aliases
for part in parts.iter() { for part in parts.iter() {
if part.contains(&b'~') { if part.contains(&b'~') {
let mut split = part.splitn(1, |b| *b == b'~'); let mut split = part.splitn(2, |b| *b == b'~');
let first = let first =
split.next().unwrap().to_owned().to_ascii_uppercase(); split.next().unwrap().to_owned().to_ascii_uppercase();
let last = split.next().unwrap(); let last = split.next().unwrap();
if last.iter().all(u8::is_ascii_digit) if last.iter().all(u8::is_ascii_digit)
&& (first == b"HG" || first == b"HG8B6C") && (first == b"HG" || first == b"HG8B6C")
{ {
return Err(HgPathError::ContainsIllegalComponent( return Err(HgPathError::ContainsIllegalComponent(
path.to_owned(), path.to_owned(),