This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8212

rust-pathauditor: actually populate the `audited_dirs` cache
ClosedPublic

Authored by Alphare on Mar 4 2020, 9:45 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG8a237131ff0f: rust-pathauditor: actually populate the `audited_dirs` cache
Summary

I forgot this when rewriting this logic during the review process.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

Alphare created this revision.Mar 4 2020, 9:45 AM
Alphare added a commit: rHG8a237131ff0f: rust-pathauditor: actually populate the `audited_dirs` cache.Mar 11 2020, 12:25 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG8a237131ff0f: rust-pathauditor: actually populate the `audited_dirs` cache (authored by Alphare). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 20447

rust/hg-core/src/utils/path_auditor.rs

// is potentially expensive to access). // is potentially expensive to access).
for index in 0..parts.len() { for index in 0..parts.len() {
let prefix = &parts[..index + 1].join(&b'/'); let prefix = &parts[..index + 1].join(&b'/');
let prefix = HgPath::new(prefix); let prefix = HgPath::new(prefix);
if self.audited_dirs.contains(prefix) { if self.audited_dirs.contains(prefix) {
continue; continue;
} }
self.check_filesystem(&prefix, &path)?; self.check_filesystem(&prefix, &path)?;
self.audited_dirs.insert(prefix.to_owned());
} }
self.audited.insert(path.to_owned()); self.audited.insert(path.to_owned());
Ok(()) Ok(())
} }
pub fn check_filesystem( pub fn check_filesystem(