Page MenuHomePhabricator

hg-core: add a compilation error if trying to compile outside of Linux
ClosedPublic

Authored by Alphare on Mar 6 2020, 5:19 AM.

Details

Summary

For now, we can only provide support for Linux in hg-core, so we have to be
explicit about it in case anyone wonders why their Dirstate is suddenly broken,
or why the crate does not compile (on Windows for example).

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Alphare created this revision.Mar 6 2020, 5:19 AM
pulkit accepted this revision.Mon, Mar 9, 4:53 AM
This revision is now accepted and ready to land.Mon, Mar 9, 4:53 AM

Forgot to mention, I tried to apply this patch on default and it failed. Now I see it's targeted for stable. Since most of the rust code is experimental/not much used, it should be fine to have this on default branch. Any reason why this is targeted for stable?

yuja added a subscriber: yuja.Thu, Mar 12, 9:02 AM

+/ Remove this to see (potential) non-artificial compile failures. MacOS
+
/ *should* compile, but fail to compile tests for example as of 2020-03-06

Un-doccommented this to silence build warning.

In D8246#123554, @yuja wrote:

+/ Remove this to see (potential) non-artificial compile failures. MacOS
+
/ *should* compile, but fail to compile tests for example as of 2020-03-06

Un-doccommented this to silence build warning.

Thanks, good catch.