This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8262

git: add readfast() method to manifest
ClosedPublic

Authored by durin42 on Mar 7 2020, 4:51 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG7518ea76eff4: git: add readfast() method to manifest
rHG4f5b730365e7: git: add readfast() method to manifest
rHGff465d38cf45: git: add readfast() method to manifest
Summary

Mysteriously, on a different system a handful of things don't work
without this, including log. This is especially odd to be because log
works in the test. In any event, it's legal for readfast() to just
return read(), so that's what we do.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

durin42 created this revision.Mar 7 2020, 4:51 PM
martinvonz added a subscriber: martinvonz.Mar 7 2020, 5:03 PM

FYI, I saw this failure on hg log -r with an partial nodeid.

pulkit accepted this revision.Mar 9 2020, 4:59 AM
pulkit added a subscriber: pulkit.

Looks like we should test the interfaces.

This revision is now accepted and ready to land.Mar 9 2020, 4:59 AM
durin42 added a commit: rHGff465d38cf45: git: add readfast() method to manifest.Mar 9 2020, 6:03 AM
Closed by commit rHGff465d38cf45: git: add readfast() method to manifest (authored by durin42). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/git/manifest.py (3 lines)

Diff 20611

hgext/git/manifest.py

class gittreemanifestctx(object): class gittreemanifestctx(object):
def __init__(self, repo, gittree): def __init__(self, repo, gittree):
self._repo = repo self._repo = repo
self._tree = gittree self._tree = gittree
def read(self): def read(self):
return gittreemanifest(self._repo, self._tree, None) return gittreemanifest(self._repo, self._tree, None)
def readfast(self, shallow=False):
return self.read()
def copy(self): def copy(self):
# NB: it's important that we return a memgittreemanifestctx # NB: it's important that we return a memgittreemanifestctx
# because the caller expects a mutable manifest. # because the caller expects a mutable manifest.
return memgittreemanifestctx(self._repo, self._tree) return memgittreemanifestctx(self._repo, self._tree)
def find(self, path): def find(self, path):
self.read()[path] self.read()[path]