Page MenuHomePhabricator

run-tests: restrict Rust thread pool to 3 threads during tests
ClosedPublic

Authored by Alphare on Tue, Mar 10, 11:28 AM.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Alphare created this revision.Tue, Mar 10, 11:28 AM
pulkit added a subscriber: pulkit.Tue, Mar 10, 12:33 PM
pulkit added inline comments.
tests/run-tests.py
3002

Should we also take value of -j into account too? If -j 1 is used, then we should not do multi-threading here.

durin42 accepted this revision as: durin42.Tue, Mar 10, 4:34 PM
durin42 added a subscriber: durin42.
durin42 added inline comments.
tests/run-tests.py
3002

I don't think so, since part of the goal is to uncover threading bugs.

marmoute added inline comments.
tests/run-tests.py
3002

I don't think we should take -j in account. Even if we run test one at a time, it is important to test the multithreading code path

marmoute accepted this revision.Wed, Mar 11, 11:56 AM
This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.