Page MenuHomePhabricator

tests: collect all branch creation in one place in test-copies-chain-merge.t
ClosedPublic

Authored by martinvonz on Apr 2 2020, 4:59 PM.

Details

Summary

I found this test case really hard to read because it requires
scrolling back and forth between the setup and the verification. The
next patch will move the verification close to the merge commits they
test. This patch prepares for that by moving all branch creation first
so they are separate from the merge commits (because many merge
commits reuse the same branches).

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Apr 2 2020, 4:59 PM
pulkit accepted this revision.Apr 7 2020, 8:29 AM
pulkit added a subscriber: pulkit.

I was trying to understand what's going on the test modified here and this patch helped me. Thanks!

This revision is now accepted and ready to land.Apr 7 2020, 8:29 AM

I would prefer you wait for planned change to land before you do further change to the file. The coming changes fixes bug and I rather not have to fix too many conflict while doing so.

pulkit added a comment.Apr 7 2020, 9:07 AM

I would prefer you wait for planned change to land before you do further change to the file. The coming changes fixes bug and I rather not have to fix too many conflict while doing so.

I already pushed them, I will resolve conflicts on those couple of patches and update them on heptapod.

I would prefer you wait for planned change to land before you do further change to the file. The coming changes fixes bug and I rather not have to fix too many conflict while doing so.

I already pushed them, I will resolve conflicts on those couple of patches and update them on heptapod.

Thanks, Pulkit!