This is an archive of the discontinued Mercurial Phabricator instance.

remotefilelog: remove copy-paste in fastlog logging
ClosedPublic

Authored by stash on Sep 28 2017, 12:54 PM.
Tags
None
Subscribers
None

Details

Reviewers
quark
Group Reviewers
Restricted Project
Commits
rFBHGXc8760e5083d2: remotefilelog: remove copy-paste in fastlog logging
Summary

The goal of the whole series is to have logging around linknode fixup. It's a slow operation, and we have two heuristics to make it faster. Unfortunately we have no idea about how well these heuristics actually help. This series of diffs aims to fix this problem. After this series is landed and logging is enabled, I hope that we can find out if we really these heuristics at all.

Test Plan

Run test-remotefilelog-linknodes.t

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Branch
default
Lint
Lint OK
Unit
Unit Test Errors

Event Timeline

stash created this revision.Sep 28 2017, 12:54 PM
stash edited the summary of this revision. (Show Details)Sep 28 2017, 1:10 PM
quark accepted this revision.Sep 29 2017, 8:48 PM
This revision is now accepted and ready to land.Sep 29 2017, 8:48 PM
This revision was automatically updated to reflect the committed changes.