Page MenuHomePhabricator

fastexport: fix diagnostics
ClosedPublic

Authored by joerg.sonnenberger on Apr 10 2020, 4:33 PM.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit accepted this revision.Apr 13 2020, 11:49 AM
This revision is now accepted and ready to land.Apr 13 2020, 11:49 AM
pulkit added inline comments.Apr 13 2020, 11:51 AM
hgext/fastexport.py
36

Removed this unrequired change to make test-check-format.t happy.

This revision was automatically updated to reflect the committed changes.

What was broken before? The test case still seems to pass for me if I undo the code change.

Think about any attempt to localize the error message.

Think about any attempt to localize the error message.

Would have helped to put that in the commit message. So the pycompat.bytestr() call is unrelated and not needed, right?

Think about any attempt to localize the error message.

Would have helped to put that in the commit message. So the pycompat.bytestr() call is unrelated and not needed, right?

I'll update it in flight with a new commit message and without the pycompat.bytestr().