( )⚙ D8415 nodemap: add a new mode value, "strict"

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8415

nodemap: add a new mode value, "strict"
ClosedPublic

Authored by marmoute on Apr 14 2020, 11:48 AM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHG6b01799e9db0: nodemap: add a new mode value, "strict"
Summary

When "strict" is set, operation will refuse to use the slow path and abort if
they would. This is useful for testing, benchmarking and server operation.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Apr 14 2020, 11:48 AM
marmoute updated this revision to Diff 21093.Apr 15 2020, 7:59 AM
Alphare accepted this revision.May 7 2020, 9:03 AM
marmoute added a commit: rHG6b01799e9db0: nodemap: add a new mode value, "strict".May 7 2020, 11:33 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG6b01799e9db0: nodemap: add a new mode value, "strict" (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 21291

mercurial/revlogutils/nodemap.py

ondisk_docket = revlog._nodemap_docket ondisk_docket = revlog._nodemap_docket
feed_data = util.safehasattr(revlog.index, "update_nodemap_data") feed_data = util.safehasattr(revlog.index, "update_nodemap_data")
use_mmap = revlog.opener.options.get(b"exp-persistent-nodemap.mmap") use_mmap = revlog.opener.options.get(b"exp-persistent-nodemap.mmap")
mode = revlog.opener.options.get(b"exp-persistent-nodemap.mode") mode = revlog.opener.options.get(b"exp-persistent-nodemap.mode")
if not can_incremental: if not can_incremental:
msg = _(b"persistent nodemap in strict mode without efficient method") msg = _(b"persistent nodemap in strict mode without efficient method")
if mode == b'warn': if mode == b'warn':
tr._report(b"%s\n" % msg) tr._report(b"%s\n" % msg)
elif mode == b'strict':
raise error.Abort(msg)
data = None data = None
# first attemp an incremental update of the data # first attemp an incremental update of the data
if can_incremental and ondisk_docket is not None: if can_incremental and ondisk_docket is not None:
target_docket = revlog._nodemap_docket.copy() target_docket = revlog._nodemap_docket.copy()
( (
src_docket, src_docket,
data_changed_count, data_changed_count,

tests/test-persistent-nodemap.t

revision in nodemap: 5001 revision in nodemap: 5001
add a new commit add a new commit
$ hg up $ hg up
5001 files updated, 0 files merged, 0 files removed, 0 files unresolved 5001 files updated, 0 files merged, 0 files removed, 0 files unresolved
$ echo foo > foo $ echo foo > foo
$ hg add foo $ hg add foo
#if no-pure no-rust
$ hg ci -m 'foo' --config "experimental.exp-persistent-nodemap.mode=strict"
transaction abort!
rollback completed
abort: persistent nodemap in strict mode without efficient method
[255]
#endif
$ hg ci -m 'foo' $ hg ci -m 'foo'
#if no-pure no-rust #if no-pure no-rust
$ hg debugnodemap --metadata $ hg debugnodemap --metadata
uid: ???????????????? (glob) uid: ???????????????? (glob)
tip-rev: 5001 tip-rev: 5001
tip-node: 16395c3cf7e231394735e6b1717823ada303fb0c tip-node: 16395c3cf7e231394735e6b1717823ada303fb0c
data-length: 121088 data-length: 121088