Page MenuHomePhabricator

upgrade: support upgrade and downgrade from persistent nodemap
ClosedPublic

Authored by marmoute on Apr 15 2020, 4:16 PM.

Details

Summary

The requirements is now recognised and dealt with and the associated files
properly handled.

The persistent nodemap should be ready for usage in the field now.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Apr 15 2020, 4:16 PM
mharbison72 accepted this revision.Apr 16 2020, 9:51 AM
mharbison72 added a subscriber: mharbison72.

s/requirements is not/requirement is now/ in the summary, but otherwise LGTM

Alphare accepted this revision.Thu, May 7, 9:26 AM
Alphare added a subscriber: Alphare.

Same remark as Matt.

marmoute edited the summary of this revision. (Show Details)Thu, May 7, 10:13 AM

s/requirements is not/requirement is now/ in the summary, but otherwise LGTM

Good catch, fixing it now.

durin42 requested changes to this revision.Thu, May 7, 11:17 AM
durin42 added a subscriber: durin42.

This requirement needs documentation in mercurial/helptext/internals/requirements.txt. I've taken the rest of the stack, but am blocking this patch on that change.

This revision now requires changes to proceed.Thu, May 7, 11:17 AM
marmoute updated this revision to Diff 21315.Thu, May 7, 5:01 PM
durin42 added inline comments.Mon, May 11, 5:08 PM
mercurial/helptext/internals/requirements.txt
150

The parenthetical on this line isn't closed. Should we just drop the opening paren?

155

nit: installations (should be plural, also has typo)

156

"Other installations ..."

marmoute updated this revision to Diff 21349.Tue, May 12, 4:36 AM
This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.