This is an archive of the discontinued Mercurial Phabricator instance.

upgrade: support upgrade and downgrade from persistent nodemap
ClosedPublic

Authored by marmoute on Apr 15 2020, 4:16 PM.

Details

Summary

The requirements is now recognised and dealt with and the associated files
properly handled.

The persistent nodemap should be ready for usage in the field now.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

marmoute created this revision.Apr 15 2020, 4:16 PM
mharbison72 accepted this revision.Apr 16 2020, 9:51 AM
mharbison72 added a subscriber: mharbison72.

s/requirements is not/requirement is now/ in the summary, but otherwise LGTM

Alphare accepted this revision.May 7 2020, 9:26 AM
Alphare added a subscriber: Alphare.

Same remark as Matt.

marmoute edited the summary of this revision. (Show Details)May 7 2020, 10:13 AM

s/requirements is not/requirement is now/ in the summary, but otherwise LGTM

Good catch, fixing it now.

durin42 requested changes to this revision.May 7 2020, 11:17 AM
durin42 added a subscriber: durin42.

This requirement needs documentation in mercurial/helptext/internals/requirements.txt. I've taken the rest of the stack, but am blocking this patch on that change.

This revision now requires changes to proceed.May 7 2020, 11:17 AM
marmoute updated this revision to Diff 21315.May 7 2020, 5:01 PM
durin42 added inline comments.May 11 2020, 5:08 PM
mercurial/helptext/internals/requirements.txt
150 ↗(On Diff #21315)

The parenthetical on this line isn't closed. Should we just drop the opening paren?

155 ↗(On Diff #21315)

nit: installations (should be plural, also has typo)

156 ↗(On Diff #21315)

"Other installations ..."

marmoute updated this revision to Diff 21349.May 12 2020, 4:36 AM
This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.