This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8426

wait-on-file: use proper variable in math
ClosedPublic

Authored by marmoute on Apr 15 2020, 3:07 PM.

Details

Reviewers
mharbison72
pulkit
Group Reviewers
hg-reviewers
Commits
rHG694d40416d62: wait-on-file: use proper variable in math
Summary

This seems better and safer to be explicit.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Apr 15 2020, 3:07 PM
mharbison72 accepted this revision.Apr 15 2020, 6:11 PM
pulkit accepted this revision.Apr 16 2020, 4:10 AM
This revision is now accepted and ready to land.Apr 16 2020, 4:10 AM
marmoute added a commit: rHG694d40416d62: wait-on-file: use proper variable in math.Apr 16 2020, 12:55 PM
Closed by commit rHG694d40416d62: wait-on-file: use proper variable in math (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/testlib/wait-on-file (2 lines)

Diff 21144

tests/testlib/wait-on-file

if [ -n "$create" ]; if [ -n "$create" ];
then then
touch "$create" touch "$create"
create="" create=""
fi fi
while [ "$timer" -gt 0 ] && [ ! -f "$wait_on" ]; while [ "$timer" -gt 0 ] && [ ! -f "$wait_on" ];
do do
timer=$(( timer - 1)) timer=$(( $timer - 1))
sleep 0.01 sleep 0.01
done done
if [ "$timer" -le 0 ]; then if [ "$timer" -le 0 ]; then
echo "file not created after $1 seconds: $wait_on" >&2 echo "file not created after $1 seconds: $wait_on" >&2
exit 1 exit 1
fi fi