This is an archive of the discontinued Mercurial Phabricator instance.

phabricator: avoid creating unstable children within the review stack
ClosedPublic

Authored by mharbison72 on Apr 15 2020, 7:57 PM.

Details

Summary

The instability occurred when rebasing something that has already been submitted
onto something that hasn't, and then resubmitting the stack. Or as the test
shows, just resubmitting and including something earlier that wasn't previously
submitted.

There's a general case here where any children (not just the ones in the range
of commits posted for review) should be re-stabilized. But handling the
selected commits here will cause the local:commit node values that are tracked
on Phabricator to be properly kept in sync.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mharbison72 created this revision.Apr 15 2020, 7:57 PM
Alphare accepted this revision.Apr 16 2020, 9:55 AM
Alphare added a subscriber: Alphare.
Alphare added inline comments.
tests/test-phabricator.t
184

Nit: I feel like using "rebasing" is confusing as it does not involve user-level rebase.

mharbison72 added inline comments.Apr 16 2020, 11:10 AM
tests/test-phabricator.t
184

I can follow up and say "when restacking existing" after the freeze, unless someone fixes in flight.

This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.