Page MenuHomePhabricator

[RFC] metadataonlyctx: demonstrate an error reusing manifest nodes
Needs RevisionPublic

Authored by mharbison72 on Apr 17 2020, 11:19 AM.

Details

Reviewers
marmoute
Group Reviewers
hg-reviewers
Summary

Don't queue this, it's for demo purposes only.

The structure of the revisions being submitted here is admittedly insane, but I
stumbled into this trying to test for another issue. Since I don't see anything
obviously wrong, I'm wondering if fix/absorb/etc would have similar issues here.
I converted the RuntimeError to a message so that the operation completes and
doesn't rollback the transaction.

Diff Detail

Repository
rHG Mercurial
Branch
stable
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

mharbison72 created this revision.Apr 17 2020, 11:19 AM
marmoute requested changes to this revision.Apr 22 2020, 12:16 PM
marmoute added a subscriber: marmoute.

For demo purpose only → getting it out of review. Put it back in review if I am wrong.

This revision now requires changes to proceed.Apr 22 2020, 12:16 PM

For demo purpose only → getting it out of review. Put it back in review if I am wrong.

Correct. But I would like eyes on it because I have no clue what the problem is, and it might affect other extensions.

II recommend filling up a bug with a link to this Diff.

Bug filed here: https://bz.mercurial-scm.org/show_bug.cgi?id=6305

I wonder if D8989 has any effect on this.