This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8501

tests: increase internal timeouts
AbandonedPublic

Authored by joerg.sonnenberger on May 7 2020, 9:03 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Summary

The default limit is not enough time for non-rust test cases on a
Threadripper when using SMT, so bump the limit to 1/3 of the default
timeout to provide some breathing room.

Diff Detail

Repository
rHG Mercurial
Branch
stable
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

marmoute added a subscriber: marmoute.May 7 2020, 10:17 AM

Can you double check that 20 second are actually spend to timeout? Previously we had a bug were the time waited was actually 0.2 seconds (and not 20 seconds) and the test was only "flacky". So spending more than 20 seconds in there seems pretty suspicious and I suspect another misbehaving. ?

durin42 added a subscriber: durin42.May 7 2020, 11:29 AM
In D8501#126995, @marmoute wrote:

Can you double check that 20 second are actually spend to timeout? Previously we had a bug were the time waited was actually 0.2 seconds (and not 20 seconds) and the test was only "flacky". So spending more than 20 seconds in there seems pretty suspicious and I suspect another misbehaving. ?

   $ date
+  Thu May  7 15:28:09 GMT 2020
   $ wait-on-file 20 sync-txn-pending && \
   > hg debugnodemap --metadata && \
   > wait-on-file 20 sync-txn-close sync-repo-read
+  file not created after 20 seconds: sync-txn-pending
+  data-length: 121280 (pure !)
+  data-length: 121280 (rust !)
+  data-unused: 192 (pure !)
+  data-unused: 192 (rust !)
+  data-unused: 0.158% (pure !)
+  data-unused: 0.158% (rust !)
+  [1]
+  $ date
+  Thu May  7 15:28:09 GMT 2020
+  $ hg debugnodemap --metadata

so it looks like we do have another wait-on-file bug, though I'm lost as to how.

durin42 added a comment.May 7 2020, 11:32 AM

(I don't have time to do this at the moment, but I strongly suspect we'd be better off with wait-on-file as a Python script at this point.)

joerg.sonnenberger abandoned this revision.May 7 2020, 5:20 PM

Will fix the real problem.

Revision Contents
Changeset List

PathPackages
Mtests/test-persistent-nodemap.t (6 lines)

Diff 21278

tests/test-persistent-nodemap.t

data-unused: 0.156% (rust !) data-unused: 0.156% (rust !)
data-unused: 0.000% (no-pure no-rust !) data-unused: 0.000% (no-pure no-rust !)
Another process does not see the pending nodemap content during run. Another process does not see the pending nodemap content during run.
$ PATH=$RUNTESTDIR/testlib/:$PATH $ PATH=$RUNTESTDIR/testlib/:$PATH
$ echo qpoasp > a $ echo qpoasp > a
$ hg ci -m a2 \ $ hg ci -m a2 \
> --config "hooks.pretxnclose=wait-on-file 20 sync-repo-read sync-txn-pending" \ > --config "hooks.pretxnclose=wait-on-file 60 sync-repo-read sync-txn-pending" \
> --config "hooks.txnclose=touch sync-txn-close" > output.txt 2>&1 & > --config "hooks.txnclose=touch sync-txn-close" > output.txt 2>&1 &
(read the repository while the commit transaction is pending) (read the repository while the commit transaction is pending)
$ wait-on-file 20 sync-txn-pending && \ $ wait-on-file 60 sync-txn-pending && \
> hg debugnodemap --metadata && \ > hg debugnodemap --metadata && \
> wait-on-file 20 sync-txn-close sync-repo-read > wait-on-file 60 sync-txn-close sync-repo-read
uid: ???????????????? (glob) uid: ???????????????? (glob)
tip-rev: 5004 tip-rev: 5004
tip-node: ba87cd9559559e4b91b28cb140d003985315e031 tip-node: ba87cd9559559e4b91b28cb140d003985315e031
data-length: 123328 (pure !) data-length: 123328 (pure !)
data-length: 123328 (rust !) data-length: 123328 (rust !)
data-length: 123136 (no-pure no-rust !) data-length: 123136 (no-pure no-rust !)
data-unused: 192 (pure !) data-unused: 192 (pure !)
data-unused: 192 (rust !) data-unused: 192 (rust !)