Page MenuHomePhabricator

rust: fix warning about unnecessary mut
ClosedPublic

Authored by valentin.gatienbaron on May 17 2020, 12:33 PM.

Details

Summary

If there's a reason to use mut (like compability with older
compilers), then we should stick #[allow(unused_mut)] on the
declaration.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Alphare accepted this revision.May 17 2020, 2:18 PM
Alphare added a subscriber: Alphare.

This is not detected in rustc 1.34.2, it's the only reason I left it, it works without the mut indeed.

pulkit accepted this revision.May 17 2020, 4:46 PM
This revision is now accepted and ready to land.May 17 2020, 4:46 PM
This revision was automatically updated to reflect the committed changes.