This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8538

rust: fix warning about unnecessary mut
ClosedPublic

Authored by valentin.gatienbaron on May 17 2020, 12:33 PM.

Details

Reviewers
Alphare
pulkit
Group Reviewers
hg-reviewers
Commits
rHG73d6ce2746d2: rust: fix warning about unnecessary mut
Summary

If there's a reason to use mut (like compability with older
compilers), then we should stick #[allow(unused_mut)] on the
declaration.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

Alphare accepted this revision.May 17 2020, 2:18 PM
Alphare added a subscriber: Alphare.

This is not detected in rustc 1.34.2, it's the only reason I left it, it works without the mut indeed.

pulkit accepted this revision.May 17 2020, 4:46 PM
This revision is now accepted and ready to land.May 17 2020, 4:46 PM
valentin.gatienbaron added a commit: rHG73d6ce2746d2: rust: fix warning about unnecessary mut.May 17 2020, 5:18 PM
Closed by commit rHG73d6ce2746d2: rust: fix warning about unnecessary mut (authored by valentin.gatienbaron). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 21402

rust/hg-core/src/dirstate/status.rs

root_dir: impl AsRef<Path> + Sync + Send + Copy + 'c, root_dir: impl AsRef<Path> + Sync + Send + Copy + 'c,
ignore_files: Vec<PathBuf>, ignore_files: Vec<PathBuf>,
options: StatusOptions, options: StatusOptions,
) -> StatusResult<( ) -> StatusResult<(
(Vec<Cow<'c, HgPath>>, DirstateStatus<'c>), (Vec<Cow<'c, HgPath>>, DirstateStatus<'c>),
Vec<PatternFileWarning>, Vec<PatternFileWarning>,
)> { )> {
// Needs to outlive `dir_ignore_fn` since it's captured. // Needs to outlive `dir_ignore_fn` since it's captured.
let mut ignore_fn: IgnoreFnType; let ignore_fn: IgnoreFnType;
// Only involve real ignore mechanism if we're listing unknowns or ignored. // Only involve real ignore mechanism if we're listing unknowns or ignored.
let (dir_ignore_fn, warnings): (IgnoreFnType, _) = if options.list_ignored let (dir_ignore_fn, warnings): (IgnoreFnType, _) = if options.list_ignored
|| options.list_unknown || options.list_unknown
{ {
let (ignore, warnings) = get_ignore_function(ignore_files, root_dir)?; let (ignore, warnings) = get_ignore_function(ignore_files, root_dir)?;
ignore_fn = ignore; ignore_fn = ignore;