This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8581

grep: test that paths get audited
ClosedPublic

Authored by valentin.gatienbaron on May 25 2020, 7:42 PM.

Details

Reviewers
marmoute
Group Reviewers
hg-reviewers
Commits
rHG06105aa8bc0e: grep: test that paths get audited

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute requested changes to this revision.May 26 2020, 9:54 AM
marmoute added a subscriber: marmoute.

It would be nice to have some comments in the test to explain what is exactly test here, it is a bit obscure from just reading the test.

This revision now requires changes to proceed.May 26 2020, 9:54 AM
valentin.gatienbaron added a comment.May 28 2020, 12:19 PM
In D8581#128072, @marmoute wrote:

It would be nice to have some comments in the test to explain what is exactly test here, it is a bit obscure from just reading the test.

Not sure if phabricator sends a notification to reviewers, but this is addressed.

valentin.gatienbaron added a commit: rHG06105aa8bc0e: grep: test that paths get audited.May 28 2020, 12:23 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG06105aa8bc0e: grep: test that paths get audited (authored by valentin.gatienbaron). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-grep.t (9 lines)

Diff 21494

tests/test-grep.t

um:unmod um:unmod
#if symlink #if symlink
Grepping a symlink greps its destination Grepping a symlink greps its destination
$ rm -f added; ln -s symlink-added added $ rm -f added; ln -s symlink-added added
$ hg grep '' | grep added $ hg grep '' | grep added
added:symlink-added added:symlink-added
But we reject symlinks as directories components of a tracked file as
usual:
$ mkdir dir; touch dir/f; hg add dir/f
$ rm -rf dir; ln -s / dir
$ hg grep ''
abort: path 'dir/f' traverses symbolic link 'dir'
[255]
#endif #endif
But we can search files from some other revision with -rREV But we can search files from some other revision with -rREV
$ hg grep -r. mod $ hg grep -r. mod
um:1:unmod um:1:unmod
$ hg grep --diff mod $ hg grep --diff mod