Page MenuHomePhabricator

grep: reduce the cost of pathauditor checks when grepping working copy
ClosedPublic

Authored by valentin.gatienbaron on May 25 2020, 7:42 PM.

Details

Summary

Running time hg grep zxczxczxczxczxc -l on mozilla-central:

before:

real	0m20,000s
user	0m15,796s
sys	0m4,189s

after:

real	0m10,903s
user	0m8,964s
sys	0m1,916s

if vfs didn't call pathauditor at all:

real	0m7,781s
user	0m5,968s
sys	0m1,790s

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute accepted this revision.May 26 2020, 9:53 AM
marmoute added a subscriber: marmoute.

It would be nice to have performance number in addition to the percentage. However the change looks good as is.

I don't understand. Do you mean have numbers in the code in addition to the commit description? Seems like too much details.

I don't understand. Do you mean have numbers in the code in addition to the commit description? Seems like too much details.

Hum, I got confused, I remember seeing a changeset with percentage speed up only in description. This is -clearly- not this one however.

This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.