This is an archive of the discontinued Mercurial Phabricator instance.

In D8581#128072, @marmoute wrote:

It would be nice to have some comments in the test to explain what is exactly test here, it is a bit obscure from just reading the test.

Not sure if phabricator sends a notification to reviewers, but this is addressed.

valentin.gatienbaron added a commit: rHG06105aa8bc0e: grep: test that paths get audited.May 28 2020, 12:23 PM

This revision was not accepted when it landed; it landed in state Needs Review.

Closed by commit rHG06105aa8bc0e: grep: test that paths get audited (authored by valentin.gatienbaron). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			tests/test-grep.t (9 lines)

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	21468		May 25 2020, 7:42 PM	★	★
Diff 2	21486		May 26 2020, 12:55 PM	★	★
Diff 3	21494	rHG06105aa8bc0e109905ede39ed591132a7e006d66	May 25 2020, 5:32 PM	★	★

Commit	Parents	Author	Summary	Date
b78724774314	0d8825696297	Valentin Gatien-Baron		May 25 2020, 5:32 PM

Status	Author	Revision
Closed	valentin.gatienbaron	D8582 grep: reduce the cost of pathauditor checks when grepping working copy
Closed	valentin.gatienbaron	D8581 grep: test that paths get audited
Closed	valentin.gatienbaron	D8580 grep: add test coverage of behavior on symlinks

Diff 21486

tests/test-grep.t

	um:unmod			um:unmod

	#if symlink			#if symlink
	Grepping a symlink greps its destination			Grepping a symlink greps its destination

	$ rm -f added; ln -s symlink-added added			$ rm -f added; ln -s symlink-added added
	$ hg grep '' \| grep added			$ hg grep '' \| grep added
	added:symlink-added			added:symlink-added

				But we reject symlinks as directories components of a tracked file as
				usual:

				$ mkdir dir; touch dir/f; hg add dir/f
				$ rm -rf dir; ln -s / dir
				$ hg grep ''
				abort: path 'dir/f' traverses symbolic link 'dir'
				[255]
	#endif			#endif

	But we can search files from some other revision with -rREV			But we can search files from some other revision with -rREV

	$ hg grep -r. mod			$ hg grep -r. mod
	um:1:unmod			um:1:unmod

	$ hg grep --diff mod			$ hg grep --diff mod

This is an archive of the discontinued Mercurial Phabricator instance.

grep: test that paths get auditedClosedPublic

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 21486

tests/test-grep.t

grep: test that paths get audited
ClosedPublic

Revision Contents
Changeset List