This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8617

tests: consistently use pyflakes as a Python module
ClosedPublic

Authored by av6 on Jun 6 2020, 7:31 AM.

Details

Reviewers
mjacob
pulkit
Group Reviewers
hg-reviewers
Commits
rHGf4361aed565d: tests: consistently use pyflakes as a Python module
Summary

We check availability of pyflakes as a module, and also running it for real as
a module. Only fair to test filterpyflakes.py working correctly when using
pyflakes as a module too.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

av6 created this revision.Jun 6 2020, 7:31 AM
mjacob accepted this revision.Jun 6 2020, 8:35 AM
mjacob added a subscriber: mjacob.
mjacob added inline comments.
tests/test-check-pyflakes.t
11

For some reason this wasn’t included in rHGe397c6d74652, although I found an earlier version of that patch on my machine including it. Probably it got lost during merge conflict resolution.

pulkit accepted this revision.Jun 9 2020, 4:59 AM
This revision is now accepted and ready to land.Jun 9 2020, 4:59 AM
av6 added a commit: rHGf4361aed565d: tests: consistently use pyflakes as a Python module.Jun 9 2020, 6:09 AM
Closed by commit rHGf4361aed565d: tests: consistently use pyflakes as a Python module (authored by av6). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-check-pyflakes.t (2 lines)

Diff 21578

tests/test-check-pyflakes.t

#require test-repo pyflakes hg10 #require test-repo pyflakes hg10
$ . "$TESTDIR/helpers-testrepo.sh" $ . "$TESTDIR/helpers-testrepo.sh"
run pyflakes on all tracked files ending in .py or without a file ending run pyflakes on all tracked files ending in .py or without a file ending
(skipping binary file random-seed) (skipping binary file random-seed)
$ cat > test.py <<EOF $ cat > test.py <<EOF
> print(undefinedname) > print(undefinedname)
> EOF > EOF
$ pyflakes test.py 2>/dev/null | "$TESTDIR/filterpyflakes.py" $ $PYTHON -m pyflakes test.py 2>/dev/null | "$TESTDIR/filterpyflakes.py"
mjacobUnsubmitted
Done

For some reason this wasn’t included in rHGe397c6d74652, although I found an earlier version of that patch on my machine including it. Probably it got lost during merge conflict resolution.

mjacob: For some reason this wasn’t included in rHGe397c6d74652, although I found an earlier version of…
test.py:1: undefined name 'undefinedname' test.py:1: undefined name 'undefinedname'
$ cd "`dirname "$TESTDIR"`" $ cd "`dirname "$TESTDIR"`"
$ testrepohg locate 'set:**.py or grep("^#!.*python")' \ $ testrepohg locate 'set:**.py or grep("^#!.*python")' \
> -X hgext/fsmonitor/pywatchman \ > -X hgext/fsmonitor/pywatchman \
> -X mercurial/pycompat.py -X contrib/python-zstandard \ > -X mercurial/pycompat.py -X contrib/python-zstandard \
> -X mercurial/thirdparty/cbor \ > -X mercurial/thirdparty/cbor \