( )⚙ D8618 tests: adjust to the new format in pyflakes output

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8618

tests: adjust to the new format in pyflakes output
ClosedPublic

Authored by av6 on Jun 6 2020, 7:31 AM.

Details

Reviewers
mjacob
pulkit
Group Reviewers
hg-reviewers
Commits
rHG3d409f4ff46b: tests: adjust to the new format in pyflakes output
Summary

According to the pyflakes' NEWS.rst, the default output format changed
recently:

2.2.0 (2020-04-08)
- Include column information in error messages

So the lines now read:

contrib/perf.py:149:15 undefined name 'xrange'
mercurial/hgweb/server.py:427:13 undefined name 'reload'
mercurial/util.py:2862:24 undefined name 'file'

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

av6 created this revision.Jun 6 2020, 7:31 AM
mjacob added a subscriber: mjacob.Jun 6 2020, 8:43 AM

Personally, I would have used REs in the first place, but since they were already using globs, this LGTM.

mjacob accepted this revision.Jun 6 2020, 8:43 AM
pulkit accepted this revision.Jun 9 2020, 5:00 AM
This revision is now accepted and ready to land.Jun 9 2020, 5:00 AM
av6 added a commit: rHG3d409f4ff46b: tests: adjust to the new format in pyflakes output.Jun 9 2020, 6:10 AM
Closed by commit rHG3d409f4ff46b: tests: adjust to the new format in pyflakes output (authored by av6). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-check-pyflakes.t (10 lines)

Diff 21579

tests/test-check-pyflakes.t

#require test-repo pyflakes hg10 #require test-repo pyflakes hg10
$ . "$TESTDIR/helpers-testrepo.sh" $ . "$TESTDIR/helpers-testrepo.sh"
run pyflakes on all tracked files ending in .py or without a file ending run pyflakes on all tracked files ending in .py or without a file ending
(skipping binary file random-seed) (skipping binary file random-seed)
$ cat > test.py <<EOF $ cat > test.py <<EOF
> print(undefinedname) > print(undefinedname)
> EOF > EOF
$ $PYTHON -m pyflakes test.py 2>/dev/null | "$TESTDIR/filterpyflakes.py" $ $PYTHON -m pyflakes test.py 2>/dev/null | "$TESTDIR/filterpyflakes.py"
test.py:1: undefined name 'undefinedname' test.py:1:* undefined name 'undefinedname' (glob)
$ cd "`dirname "$TESTDIR"`" $ cd "`dirname "$TESTDIR"`"
$ testrepohg locate 'set:**.py or grep("^#!.*python")' \ $ testrepohg locate 'set:**.py or grep("^#!.*python")' \
> -X hgext/fsmonitor/pywatchman \ > -X hgext/fsmonitor/pywatchman \
> -X mercurial/pycompat.py -X contrib/python-zstandard \ > -X mercurial/pycompat.py -X contrib/python-zstandard \
> -X mercurial/thirdparty/cbor \ > -X mercurial/thirdparty/cbor \
> -X mercurial/thirdparty/concurrent \ > -X mercurial/thirdparty/concurrent \
> -X mercurial/thirdparty/zope \ > -X mercurial/thirdparty/zope \
> 2>/dev/null \ > 2>/dev/null \
> | xargs $PYTHON -m pyflakes 2>/dev/null | "$TESTDIR/filterpyflakes.py" > | xargs $PYTHON -m pyflakes 2>/dev/null | "$TESTDIR/filterpyflakes.py"
contrib/perf.py:*: undefined name 'xrange' (glob) (?) contrib/perf.py:*:* undefined name 'xrange' (glob) (?)
mercurial/hgweb/server.py:*: undefined name 'reload' (glob) (?) mercurial/hgweb/server.py:*:* undefined name 'reload' (glob) (?)
mercurial/util.py:*: undefined name 'file' (glob) (?) mercurial/util.py:*:* undefined name 'file' (glob) (?)
mercurial/encoding.py:*: undefined name 'localstr' (glob) (?) mercurial/encoding.py:*:* undefined name 'localstr' (glob) (?)