This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8621

phabricator: make it clear what happen when no response
ClosedPublic

Authored by khanchi97 on Jun 9 2020, 12:32 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG7a0a1be721a3: phabricator: make it clear what happen when no response

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

khanchi97 created this revision.Jun 9 2020, 12:32 PM
pulkit accepted this revision.Jun 9 2020, 1:18 PM
This revision is now accepted and ready to land.Jun 9 2020, 1:18 PM
khanchi97 added a commit: rHG7a0a1be721a3: phabricator: make it clear what happen when no response.Jun 9 2020, 1:52 PM
Closed by commit rHG7a0a1be721a3: phabricator: make it clear what happen when no response (authored by khanchi97). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/phabricator.py (2 lines)
Mtests/test-phabricator.t (4 lines)

Diff 21591

hgext/phabricator.py

% ( % (
drevdesc, drevdesc,
ui.label(bytes(ctx), b'phabricator.node'), ui.label(bytes(ctx), b'phabricator.node'),
ui.label(desc, b'phabricator.desc'), ui.label(desc, b'phabricator.desc'),
) )
) )
if ui.promptchoice( if ui.promptchoice(
_(b'Send the above changes to %s (yn)?$$ &Yes $$ &No') % url _(b'Send the above changes to %s (Y/n)?$$ &Yes $$ &No') % url
): ):
return False return False
return True return True
_knownstatusnames = { _knownstatusnames = {
b'accepted', b'accepted',

tests/test-phabricator.t

... as does the initial mutable fold... ... as does the initial mutable fold...
$ echo y | hg phabsend --fold --confirm -r 1:: \ $ echo y | hg phabsend --fold --confirm -r 1:: \
> --test-vcr "$VCR/phabsend-fold-initial.json" > --test-vcr "$VCR/phabsend-fold-initial.json"
NEW - a959a3f69d8d: one: first commit to review NEW - a959a3f69d8d: one: first commit to review
NEW - 24a4438154ba: two: second commit to review NEW - 24a4438154ba: two: second commit to review
NEW - d235829e802c: 3: a commit with no detailed message NEW - d235829e802c: 3: a commit with no detailed message
Send the above changes to https://phab.mercurial-scm.org/ (yn)? y Send the above changes to https://phab.mercurial-scm.org/ (Y/n)? y
D8387 - created - a959a3f69d8d: one: first commit to review D8387 - created - a959a3f69d8d: one: first commit to review
D8387 - created - 24a4438154ba: two: second commit to review D8387 - created - 24a4438154ba: two: second commit to review
D8387 - created - d235829e802c: 3: a commit with no detailed message D8387 - created - d235829e802c: 3: a commit with no detailed message
updating local commit list for D8387 updating local commit list for D8387
new commits: ['602c4e738243', '832553266fe8', '921f8265efbd'] new commits: ['602c4e738243', '832553266fe8', '921f8265efbd']
saved backup bundle to $TESTTMP/folded/.hg/strip-backup/a959a3f69d8d-a4a24136-phabsend.hg saved backup bundle to $TESTTMP/folded/.hg/strip-backup/a959a3f69d8d-a4a24136-phabsend.hg
... and doesn't mangle the local commits. ... and doesn't mangle the local commits.
> --test-vcr "$VCR/phabsend-fold-updated.json" > --test-vcr "$VCR/phabsend-fold-updated.json"
obsolete feature not enabled but 2 markers found! obsolete feature not enabled but 2 markers found!
602c4e738243 mapped to old nodes ['602c4e738243'] 602c4e738243 mapped to old nodes ['602c4e738243']
0124e5474c88 mapped to old nodes ['832553266fe8'] 0124e5474c88 mapped to old nodes ['832553266fe8']
e4edb1fe3565 mapped to old nodes ['921f8265efbd'] e4edb1fe3565 mapped to old nodes ['921f8265efbd']
D8387 - 602c4e738243: one: first commit to review D8387 - 602c4e738243: one: first commit to review
D8387 - 0124e5474c88: two: second commit to review D8387 - 0124e5474c88: two: second commit to review
D8387 - e4edb1fe3565: 3: a commit with no detailed message D8387 - e4edb1fe3565: 3: a commit with no detailed message
Send the above changes to https://phab.mercurial-scm.org/ (yn)? y Send the above changes to https://phab.mercurial-scm.org/ (Y/n)? y
D8387 - updated - 602c4e738243: one: first commit to review D8387 - updated - 602c4e738243: one: first commit to review
D8387 - updated - 0124e5474c88: two: second commit to review D8387 - updated - 0124e5474c88: two: second commit to review
D8387 - updated - e4edb1fe3565: 3: a commit with no detailed message D8387 - updated - e4edb1fe3565: 3: a commit with no detailed message
obsolete feature not enabled but 2 markers found! (?) obsolete feature not enabled but 2 markers found! (?)
updating local commit list for D8387 updating local commit list for D8387
new commits: ['602c4e738243', '0124e5474c88', 'e4edb1fe3565'] new commits: ['602c4e738243', '0124e5474c88', 'e4edb1fe3565']
$ hg log -Tcompact $ hg log -Tcompact
obsolete feature not enabled but 2 markers found! obsolete feature not enabled but 2 markers found!