This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8647

run-tests: replace '#' with '-' in temp path of repos created for tests
ClosedPublic

Authored by pulkit on Jun 22 2020, 5:36 AM.

Download Raw Diff

Details

Reviewers

Alphare

Group Reviewers

hg-reviewers

Commits

rHGa659d5a4d2d5: run-tests: replace '#' with '-' in temp path of repos created for tests

Summary

If we have multiple cases in a test, that leads us to a temp path of
format "<temp-path>-<case1>#<case2>".
This leads to hg.parseurl() parsing the path and take part
after # as a branch name.

I encountered this bug while adding support for share-safe case in next patch.

Diff Detail

Repository

rHG Mercurial

Branch

default

Lint

No Linters Available

Unit

No Unit Test Coverage

Event Timeline

pulkit created this revision.Jun 22 2020, 5:36 AM

Herald added a reviewer: hg-reviewers. · View Herald TranscriptJun 22 2020, 5:36 AM

Herald added a subscriber: mercurial-patches. · View Herald Transcript

pulkit added a child revision: D8633: share: introduce config option to store requires in .hg/store.Jun 22 2020, 5:36 AM

pulkit updated this revision to Diff 21739.Jul 1 2020, 6:00 AM

Alphare accepted this revision.Jul 15 2020, 12:10 PM

pulkit added a commit: rHGa659d5a4d2d5: run-tests: replace '#' with '-' in temp path of repos created for tests.Jul 15 2020, 12:12 PM

This revision was not accepted when it landed; it landed in state Needs Review.

Closed by commit rHGa659d5a4d2d5: run-tests: replace '#' with '-' in temp path of repos created for tests (authored by pulkit). · Explain Why

This revision was automatically updated to reflect the committed changes.

pulkit removed a child revision: D8633: share: introduce config option to store requires in .hg/store.Jul 21 2020, 9:42 AM

Revision Contents
Changeset List

			Path	Packages
M			tests/run-tests.py (2 lines)

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	21676		Jun 22 2020, 5:35 AM	★	★
Diff 2	21739		Jul 1 2020, 5:59 AM	★	★
Diff 3	21909	rHGa659d5a4d2d57970643a8f18c3f0f8391cf574dc	Jun 22 2020, 4:21 AM	★	★

Commit	Parents	Author	Summary	Date
a29ea3d0ce48	a1de27b01dd0	Pulkit Goyal		Jun 22 2020, 4:21 AM

Status	Author	Revision
Closed	pulkit	D8647 run-tests: replace '#' with '-' in temp path of repos created for tests
Closed	pulkit	D8632 debugcommands: introduce new debugrequirements command
Closed	pulkit	D8631 scmutil: add writereporequirements() and route requires writing through it

Diff 21739

tests/run-tests.py

	case = kwds.pop('case', [])			case = kwds.pop('case', [])
	self._case = case			self._case = case
	self._allcases = {x for y in parsettestcases(path) for x in y}			self._allcases = {x for y in parsettestcases(path) for x in y}
	super(TTest, self).__init__(path, args, *kwds)			super(TTest, self).__init__(path, args, *kwds)
	if case:			if case:
	casepath = b'#'.join(case)			casepath = b'#'.join(case)
	self.name = '%s#%s' % (self.name, _bytes2sys(casepath))			self.name = '%s#%s' % (self.name, _bytes2sys(casepath))
	self.errpath = b'%s#%s.err' % (self.errpath[:-4], casepath)			self.errpath = b'%s#%s.err' % (self.errpath[:-4], casepath)
	self._tmpname += b'-%s' % casepath			self._tmpname += b'-%s' % casepath.replace(b'#', b'-')
	self._have = {}			self._have = {}

	@property			@property
	def refpath(self):			def refpath(self):
	return os.path.join(self._testdir, self.bname)			return os.path.join(self._testdir, self.bname)

	def _run(self, env):			def _run(self, env):
	with open(self.path, 'rb') as f:			with open(self.path, 'rb') as f: