This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8647

run-tests: replace '#' with '-' in temp path of repos created for tests
ClosedPublic

Authored by pulkit on Jun 22 2020, 5:36 AM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHGa659d5a4d2d5: run-tests: replace '#' with '-' in temp path of repos created for tests
Summary

If we have multiple cases in a test, that leads us to a temp path of
format "<temp-path>-<case1>#<case2>".
This leads to hg.parseurl() parsing the path and take part
after # as a branch name.

I encountered this bug while adding support for share-safe case in next patch.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Revision Contents
Changeset List

PathPackages
Mtests/run-tests.py (2 lines)

Diff 21909

tests/run-tests.py

case = kwds.pop('case', []) case = kwds.pop('case', [])
self._case = case self._case = case
self._allcases = {x for y in parsettestcases(path) for x in y} self._allcases = {x for y in parsettestcases(path) for x in y}
super(TTest, self).__init__(path, *args, **kwds) super(TTest, self).__init__(path, *args, **kwds)
if case: if case:
casepath = b'#'.join(case) casepath = b'#'.join(case)
self.name = '%s#%s' % (self.name, _bytes2sys(casepath)) self.name = '%s#%s' % (self.name, _bytes2sys(casepath))
self.errpath = b'%s#%s.err' % (self.errpath[:-4], casepath) self.errpath = b'%s#%s.err' % (self.errpath[:-4], casepath)
self._tmpname += b'-%s' % casepath self._tmpname += b'-%s' % casepath.replace(b'#', b'-')
self._have = {} self._have = {}
@property @property
def refpath(self): def refpath(self):
return os.path.join(self._testdir, self.bname) return os.path.join(self._testdir, self.bname)
def _run(self, env): def _run(self, env):
with open(self.path, 'rb') as f: with open(self.path, 'rb') as f: