( )⚙ D8658 commands: use any() instead of `if a or b or c`

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8658

commands: use any() instead of `if a or b or c`
ClosedPublic

Authored by pulkit on Jun 25 2020, 4:53 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG44d5233e66a9: commands: use any() instead of `if a or b or c`
Summary

Small cleanup for future when we have an option to show configs from shared rc.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

pulkit created this revision.Jun 25 2020, 4:53 AM
joerg.sonnenberger added a subscriber: joerg.sonnenberger.Jun 30 2020, 8:26 PM

Please use a tulpe for editopts so that it is a constant by itself.

pulkit updated this revision to Diff 21743.Jul 1 2020, 6:01 AM
marmoute added a commit: rHG44d5233e66a9: commands: use any() instead of `if a or b or c`.Jul 15 2020, 12:15 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG44d5233e66a9: commands: use any() instead of `if a or b or c` (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/commands.py (3 lines)

Diff 21743

mercurial/commands.py

:source: String. Filename and line number where the item is defined. :source: String. Filename and line number where the item is defined.
:value: String. Config value. :value: String. Config value.
Returns 0 on success, 1 if NAME does not exist. Returns 0 on success, 1 if NAME does not exist.
""" """
opts = pycompat.byteskwargs(opts) opts = pycompat.byteskwargs(opts)
if opts.get(b'edit') or opts.get(b'local') or opts.get(b'global'): editopts = (b'edit', b'local', b'global')
if any(opts.get(o) for o in editopts):
if opts.get(b'local') and opts.get(b'global'): if opts.get(b'local') and opts.get(b'global'):
raise error.Abort(_(b"can't use --local and --global together")) raise error.Abort(_(b"can't use --local and --global together"))
if opts.get(b'local'): if opts.get(b'local'):
if not repo: if not repo:
raise error.Abort(_(b"can't use --local outside a repository")) raise error.Abort(_(b"can't use --local outside a repository"))
paths = [repo.vfs.join(b'hgrc')] paths = [repo.vfs.join(b'hgrc')]
elif opts.get(b'global'): elif opts.get(b'global'):