Page MenuHomePhabricator

extdiff: refactor logic which does diff of patches
ClosedPublic

Authored by pulkit on Tue, Jul 7, 5:27 AM.

Details

Summary

The current extdiff code is hard to understand on first look. Took me few hours
to grasp the code. Before adding more things, decided to do some refactoring.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.Tue, Jul 7, 5:27 AM
Alphare accepted this revision.Wed, Jul 15, 11:50 AM
Alphare added a subscriber: Alphare.

Thanks for refactoring first!

hgext/extdiff.py
353

Could you add a small docstring?

This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.