Page MenuHomePhabricator

extdiff: add some comments in diffrevs()
ClosedPublic

Authored by pulkit on Tue, Jul 7, 5:28 AM.

Details

Summary

It was not obvious to understand the code so I added some comments.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.Tue, Jul 7, 5:28 AM
Alphare accepted this revision.Wed, Jul 15, 12:02 PM
Alphare added a subscriber: Alphare.

I'm not a big fan of the small-but-non-obvious variable names in this series, but they predate your patches, so maybe for another time.
Thanks for this series

hgext/extdiff.py
423

Nit: except files

This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.