tests/test-template-map.t
130–131	This is the line I commented on D8798 that I shouldn't have included there. As I said there, feel free to fix that in flight, or take this patch, or tell me to extract a separate patch.

martinvonz added a parent revision: D8802: tests: fix mistaken copy&paste from commit 4489e9a22763.Jul 24 2020, 1:07 AM

martinvonz updated this revision to Diff 22081.

martinvonz added inline comments.Jul 24 2020, 1:08 AM

tests/test-template-map.t
130–131	Since that review was closed, I've extracted this line into D8802.

martinvonz added a child revision: D8793: config: remove now-unused support for "includepaths".Jul 24 2020, 1:09 AM

martinvonz updated this revision to Diff 22082.Jul 24 2020, 1:39 AM

pulkit accepted this revision.Jul 24 2020, 4:31 AM

This revision is now accepted and ready to land.Jul 24 2020, 4:31 AM

martinvonz added a commit: rHGf512708a9ea8: tests: add tests trying to use dir as style, as %include, and as __base__.Jul 25 2020, 6:04 AM

Closed by commit rHGf512708a9ea8: tests: add tests trying to use dir as style, as %include, and as __base__ (authored by martinvonz). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			tests/test-template-map.t (25 lines)

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	22078		Jul 23 2020, 1:27 PM	★	★
Diff 2	22081		Jul 24 2020, 1:07 AM	★	★
Diff 3	22082		Jul 24 2020, 1:39 AM	★	★
Diff 4	22130	rHGf512708a9ea8dd045cecbf508d4c12a5b95f064e	Jul 24 2020, 1:06 AM	★	★

Status	Author	Revision
Closed	martinvonz	D8901 hgweb: enable reading styles from resources in frozen binaries
Closed	martinvonz	D8900 hgweb: rely on open_template()'s fallback to using templatedir()
Closed	martinvonz	D8899 hgweb: open mapfile using templater.open_template()
Closed	martinvonz	D8898 hgweb: simplify a constant-length list by converting to literal tuple
Closed	martinvonz	D8897 hgweb: remove some accesses to private member uimod._unset
Closed	martinvonz	D8896 templater: try to read %include in mapfiles from resources
Closed	martinvonz	D8895 templater: unroll loop over mapfile directories
Closed	martinvonz	D8894 templater: make open_template() read from resources if in frozen binary
Closed	martinvonz	D8893 templater: pass opened file-like object to templatespec
Closed	martinvonz	D8892 templater: replace templatepath() with function that also opens the file
Closed	martinvonz	D8891 templater: start passing resource to read from into _readmapfile()
Closed	martinvonz	D8890 templater: move stylemap() to hgweb_mod, since that's its only user
Closed	martinvonz	D8874 hgweb: simplify staticfile() now that we always pass it a single directory
Closed	martinvonz	D8858 packaging: include templates with their package as key in package_data
Closed	martinvonz	D8857 packaging: delete unnecessary updating of `dirs` list
Closed	martinvonz	D8856 packaging: make "mercurial.defaultrc" a key in package_data
Closed	martinvonz	D8855 packaging: mark mercurial.templates and subdirs as packages
Closed	martinvonz	D8854 templates: add __init__.py files to templates/ dirs
Closed	martinvonz	D8853 templatespec: use new factory functions in hooklib
Closed	martinvonz	D8848 templatespec: use new factory functions in logcmdutil
Closed	martinvonz	D8847 templatespec: move check for non-unicode to lower-level function
Closed	martinvonz	D8846 templatespec: logcmdutil.templatespec() gets either template or mapfile
Closed	martinvonz	D8845 templatespec: create a factory function for each type there is
Closed	martinvonz	D8844 templater: stop accepting a single style to stylemap()
Closed	martinvonz	D8807 formatter: inline a variable assigned from `templater.templater.frommapfile`
Closed	martinvonz	D8806 templater: don't normalize path separators to '/' when interacting with OS
Abandoned	martinvonz	D8809 templater: reuse check for both "map-cmdline.<name>" and "<name>"
Closed	martinvonz	D8805 formatter: remove now-unnecessary check for file-ness
Closed	martinvonz	D8804 templater: make templatepath() not return directory paths
Closed	martinvonz	D8803 tests: show unusual error message for `hg log --style coal`
Closed	martinvonz	D8796 config: remove now-unused `abs` argument from `include` callback
Closed	martinvonz	D8795 config: re-calculate absolute %include path in `include` callback
Closed	martinvonz	D8794 subrepoutil: use relative path for looking up config `%include`s
Closed	martinvonz	D8793 config: remove now-unused support for "includepaths"
Closed	martinvonz	D8800 tests: add tests trying to use dir as style, as %include, and as __base__
Closed	martinvonz	D8802 tests: fix mistaken copy&paste from commit 4489e9a22763

Diff 22130

View Options

tests: add tests trying to use dir as style, as %include, and as __base__ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 22130

tests/test-template-map.t

tests: add tests trying to use dir as style, as %include, and as base
ClosedPublic
Actions

Revision Contents
Changeset List