Page MenuHomePhabricator

tests: add test for bad template %include and __base__
ClosedPublic

Authored by martinvonz on Thu, Jul 23, 1:48 AM.

Details

Summary

It doesn't seem like we had any tests for %include non-existent and
__base__ = non-existent. The latter raises an error while the former
ignores the include. We should probably also make the former an error.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Thu, Jul 23, 1:48 AM

Unlike D8797, which I forgot to include in the series to start with, I didn't even this of these tests until later. I'm working on PyOxidizer support and I barely knew that these features existed, but I figured I'd add tests early in the series to show that the series don't change these things. A later series probably will fix that test I marked BROKEN.

pulkit accepted this revision.Thu, Jul 23, 4:41 AM
This revision is now accepted and ready to land.Thu, Jul 23, 4:41 AM
martinvonz added inline comments.Thu, Jul 23, 12:37 PM
tests/test-template-map.t
131

This line should not have been here. @pulkit, will you update the queued commit or should I send a follow-up patch?