This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8798

tests: add test for bad template %include and __base__
ClosedPublic

Authored by martinvonz on Jul 23 2020, 1:48 AM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG4489e9a22763: tests: add test for bad template %include and __base__
Summary

It doesn't seem like we had any tests for %include non-existent and
__base__ = non-existent. The latter raises an error while the former
ignores the include. We should probably also make the former an error.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Jul 23 2020, 1:48 AM
martinvonz added a comment.Jul 23 2020, 1:53 AM

Unlike D8797, which I forgot to include in the series to start with, I didn't even this of these tests until later. I'm working on PyOxidizer support and I barely knew that these features existed, but I figured I'd add tests early in the series to show that the series don't change these things. A later series probably will fix that test I marked BROKEN.

pulkit accepted this revision.Jul 23 2020, 4:41 AM
This revision is now accepted and ready to land.Jul 23 2020, 4:41 AM
martinvonz added inline comments.Jul 23 2020, 12:37 PM
tests/test-template-map.t
131

This line should not have been here. @pulkit, will you update the queued commit or should I send a follow-up patch?

Revision Contents
Changeset List

Diff 22074

tests/test-template-map.t

$ printf 'cset = "changeset: ***{rev}***\\n"\n' >> map-simple $ printf 'cset = "changeset: ***{rev}***\\n"\n' >> map-simple
$ hg log -l1 -T./map-simple $ hg log -l1 -T./map-simple
changeset: ***8*** changeset: ***8***
tag: tip tag: tip
user: test user: test
date: Wed Jan 01 10:01:00 2020 +0000 date: Wed Jan 01 10:01:00 2020 +0000
summary: third summary: third
Test map inheritance with non-existent base
$ echo "__base__ = non-existent" > map-base-nonexistent
$ printf 'cset = "changeset: ***{rev}***\\n"\n' >> map-simple
martinvonzAuthorUnsubmitted
Done

This line should not have been here. @pulkit, will you update the queued commit or should I send a follow-up patch?

martinvonz: This line should not have been here. @pulkit, will you update the queued commit or should I…
$ hg log -l1 -T./map-base-nonexistent
abort: style '$TESTTMP/a/non-existent' not found
(available styles: bisect, changelog, compact, default, phases, show, status, xml)
[255]
Test including a built-in template map Test including a built-in template map
$ cat <<'EOF' > map-include-builtin $ cat <<'EOF' > map-include-builtin
> %include map-cmdline.default > %include map-cmdline.default
> [templates] > [templates]
> changeset = "{changeset_quiet}\n" > changeset = "{changeset_quiet}\n"
> EOF > EOF
$ hg log -l1 -T./map-include-builtin $ hg log -l1 -T./map-include-builtin
8:95c24699272e 8:95c24699272e
Test including a nonexistent template map
BROKEN: This should probably be an error just like the bad __base__ above
$ cat <<'EOF' > map-include-nonexistent
> %include nonexistent
> [templates]
> changeset = "test\n"
> EOF
$ hg log -l1 -T./map-include-nonexistent
test
Test docheader, docfooter and separator in template map Test docheader, docfooter and separator in template map
$ cat <<'EOF' > map-myjson $ cat <<'EOF' > map-myjson
> docheader = '\{\n' > docheader = '\{\n'
> docfooter = '\n}\n' > docfooter = '\n}\n'
> separator = ',\n' > separator = ',\n'
> changeset = ' {dict(rev, node|short)|json}' > changeset = ' {dict(rev, node|short)|json}'
> EOF > EOF