This is an archive of the discontinued Mercurial Phabricator instance.

mergeresult: introduce action -> (filename, data, msg) mapping and related API
ClosedPublic

Authored by pulkit on Jul 25 2020, 6:02 AM.

Details

Summary

Good number of places in code, we iterate over the actions dict which has
filename as keys and filter based on the action.

This patch introduced another mapping which has action as key. This will help in
refactoring the code much more in upcoming patch.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.Jul 25 2020, 6:02 AM
indygreg accepted this revision.Aug 2 2020, 1:19 PM
indygreg added a subscriber: indygreg.

I don't like having to store some metadata redundantly in 2 dicts. I'm approving this for now under the assumption that future commits will refactor this, as the commit message and an inline comment implies.

This revision is now accepted and ready to land.Aug 2 2020, 1:19 PM