This is an archive of the discontinued Mercurial Phabricator instance.

merge: unify logic of couple of if-else's in manifestmerge()
ClosedPublic

Authored by pulkit on Jul 25 2020, 6:03 AM.

Details

Summary

Right now manifestmerge() contains very nested if-else conditions and it's not
easy to understand what is happening. I was looking for easy unifications and
found these two.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.Jul 25 2020, 6:03 AM
indygreg accepted this revision.Aug 2 2020, 1:27 PM
indygreg added a subscriber: indygreg.

I'm only +0 on this refactor, as I don't think it changes readability much. But whatever.

This revision is now accepted and ready to land.Aug 2 2020, 1:27 PM