This is an archive of the discontinued Mercurial Phabricator instance.

	Status	Author	Revision
	Closed	Kwan	D8852 phabricator: unconditionally pop `test_vcr` from kwargs to fix debugcallconduit
	Closed	Kwan	D8851 phabricator: demonstrate debugcallconduit being broken without --test-vcr

Diff 22160

	$ cd repo			$ cd repo
	$ cat >> .hg/hgrc <<EOF			$ cat >> .hg/hgrc <<EOF
	> [phabricator]			> [phabricator]
	> url = https://phab.mercurial-scm.org/			> url = https://phab.mercurial-scm.org/
	> callsign = HG			> callsign = HG
	> EOF			> EOF
	$ VCR="$TESTDIR/phabricator"			$ VCR="$TESTDIR/phabricator"

				BROKEN: debugcallconduit fails without --test-vcr:
				$ echo '{}' \| HGRCSKIPREPO= hg debugcallconduit 'conduit.ping'
				hg debugcallconduit: invalid arguments
				hg debugcallconduit METHOD

				call Conduit API

				options:

				(use 'hg debugcallconduit -h' to show more help)
				[255]

	Error is handled reasonably. We override the phabtoken here so that			Error is handled reasonably. We override the phabtoken here so that
	when you're developing changes to phabricator.py you can edit the			when you're developing changes to phabricator.py you can edit the
	above config and have a real token in the test but not have to edit			above config and have a real token in the test but not have to edit
	this test.			this test.
	$ hg phabread --config auth.hgphab.phabtoken=cli-notavalidtoken \			$ hg phabread --config auth.hgphab.phabtoken=cli-notavalidtoken \
	> --test-vcr "$VCR/phabread-conduit-error.json" D4480 \| head			> --test-vcr "$VCR/phabread-conduit-error.json" D4480 \| head
	abort: Conduit Error (ERR-INVALID-AUTH): API token "cli-notavalidtoken" has the wrong length. API tokens should be 32 characters long.			abort: Conduit Error (ERR-INVALID-AUTH): API token "cli-notavalidtoken" has the wrong length. API tokens should be 32 characters long.