Page MenuHomePhabricator

phabricator: unconditionally pop `test_vcr` from kwargs to fix debugcallconduit
ClosedPublic

Authored by Kwan on Thu, Jul 30, 12:03 PM.

Details

Summary

11592ce6a711 / D8525 accidentally broke debugcallconduit in non-test scenarios
because it stopped popping test_vcr from kwargs unconditionally, so when
--test-vcr isn't set the empty string still gets passed down as the value of
test_vcr in kwargs. However unlike all the other commands debugcallconduit
doesn't have an **opts argument to receive it, so it aborts because of
invalid arguments.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Kwan created this revision.Thu, Jul 30, 12:03 PM
pulkit accepted this revision.Fri, Jul 31, 7:44 AM
This revision is now accepted and ready to land.Fri, Jul 31, 7:44 AM