Page MenuHomePhabricator

phabricator: unconditionally pop `test_vcr` from kwargs to fix debugcallconduit
ClosedPublic

Authored by Kwan on Jul 30 2020, 12:03 PM.

Details

Summary

11592ce6a711 / D8525 accidentally broke debugcallconduit in non-test scenarios
because it stopped popping test_vcr from kwargs unconditionally, so when
--test-vcr isn't set the empty string still gets passed down as the value of
test_vcr in kwargs. However unlike all the other commands debugcallconduit
doesn't have an **opts argument to receive it, so it aborts because of
invalid arguments.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

Kwan created this revision.Jul 30 2020, 12:03 PM
pulkit accepted this revision.Jul 31 2020, 7:44 AM
This revision is now accepted and ready to land.Jul 31 2020, 7:44 AM