This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8863

hg-core: define a `ListTrackedFiles` `Operation`
ClosedPublic

Authored by acezar on Aug 3 2020, 10:25 AM.

Details

Reviewers
Alphare
indygreg
Group Reviewers
hg-reviewers
Commits
rHG0f5286ccf82c: hg-core: define a `ListTrackedFiles` `Operation`
Summary

List files under Mercurial control in the working directory.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

acezar created this revision.Aug 3 2020, 10:25 AM
Alphare accepted this revision.Aug 3 2020, 11:01 AM
acezar updated this revision to Diff 22247.Aug 4 2020, 4:57 AM
indygreg accepted this revision.Aug 8 2020, 3:50 PM
indygreg added a subscriber: indygreg.
indygreg added inline comments.
rust/hg-core/src/operations/list_tracked_files.rs
2

This file needs a header. I can add that in flight.

This revision is now accepted and ready to land.Aug 8 2020, 3:50 PM
acezar added a commit: rHG0f5286ccf82c: hg-core: define a `ListTrackedFiles` `Operation`.Aug 8 2020, 4:29 PM
Closed by commit rHG0f5286ccf82c: hg-core: define a `ListTrackedFiles` `Operation` (authored by acezar). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 22228

rust/hg-core/src/operations/list_tracked_files.rs

  • This file was added.
use super::find_root;
use crate::dirstate::parsers::parse_dirstate;
indygregUnsubmitted
Not Done

This file needs a header. I can add that in flight.

indygreg: This file needs a header. I can add that in flight.
use crate::utils::hg_path::HgPath;
use crate::{DirstateParseError, EntryState};
use rayon::prelude::*;
use std::convert::From;
use std::fmt;
use std::fs;
use std::io;
use std::path::PathBuf;
/// Kind of error encoutered by ListTrackedFiles
#[derive(Debug)]
pub enum ListTrackedFilesErrorKind {
ParseError(DirstateParseError),
}
/// A ListTrackedFiles error
#[derive(Debug)]
pub struct ListTrackedFilesError {
/// Kind of error encoutered by ListTrackedFiles
pub kind: ListTrackedFilesErrorKind,
}
impl std::error::Error for ListTrackedFilesError {}
impl fmt::Display for ListTrackedFilesError {
fn fmt(&self, _f: &mut fmt::Formatter<'_>) -> fmt::Result {
unimplemented!()
}
}
impl From<ListTrackedFilesErrorKind> for ListTrackedFilesError {
fn from(kind: ListTrackedFilesErrorKind) -> Self {
ListTrackedFilesError { kind }
}
}
/// List files under Mercurial control in the working directory
pub struct ListTrackedFiles {
root: PathBuf,
}
impl ListTrackedFiles {
pub fn new() -> Result<Self, find_root::FindRootError> {
let root = find_root::FindRoot::new().run()?;
Ok(ListTrackedFiles { root })
}
/// Load the tracked files data from disk
pub fn load(&self) -> Result<ListDirstateTrackedFiles, io::Error> {
let dirstate = &self.root.join(".hg/dirstate");
let content = fs::read(&dirstate)?;
Ok(ListDirstateTrackedFiles { content })
}
}
/// List files under Mercurial control in the working directory
/// by reading the dirstate
pub struct ListDirstateTrackedFiles {
content: Vec<u8>,
}
impl ListDirstateTrackedFiles {
pub fn run(&self) -> Result<Vec<&HgPath>, ListTrackedFilesError> {
let (_, entries, _) = parse_dirstate(&self.content)
.map_err(ListTrackedFilesErrorKind::ParseError)?;
let mut files: Vec<&HgPath> = entries
.into_iter()
.filter_map(|(path, entry)| match entry.state {
EntryState::Removed => None,
_ => Some(path),
})
.collect();
files.par_sort_unstable();
Ok(files)
}
}

rust/hg-core/src/operations/mod.rs

//! A distinction is made between operations and commands. //! A distinction is made between operations and commands.
//! An operation is what can be done whereas a command is what is exposed by //! An operation is what can be done whereas a command is what is exposed by
//! the cli. A single command can use several operations to achieve its goal. //! the cli. A single command can use several operations to achieve its goal.
mod dirstate_status; mod dirstate_status;
mod find_root; mod find_root;
mod list_tracked_files;
pub use find_root::{FindRoot, FindRootError, FindRootErrorKind}; pub use find_root::{FindRoot, FindRootError, FindRootErrorKind};
pub use list_tracked_files::{
ListTrackedFiles, ListTrackedFilesError, ListTrackedFilesErrorKind,
};
// TODO add an `Operation` trait when GAT have landed (rust #44265): // TODO add an `Operation` trait when GAT have landed (rust #44265):
// there is no way to currently define a trait which can both return // there is no way to currently define a trait which can both return
// references to `self` and to passed data, which is what we would need. // references to `self` and to passed data, which is what we would need.
// Generic Associated Types may fix this and allow us to have a unified // Generic Associated Types may fix this and allow us to have a unified
// interface. // interface.