Page MenuHomePhabricator

commit: pass mergestate into _filecommit() instead of re-reading it
ClosedPublic

Authored by pulkit on Sep 5 2020, 3:09 AM.

Details

Summary

mergestate reading although cheap is not free. Let's read mergestate once on top
and pass it into _filecommit().

In upcoming patches, we will be reading mergestate more in _filecommit().

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.Sep 5 2020, 3:09 AM
marmoute accepted this revision.Sep 11 2020, 8:58 AM
marmoute added a subscriber: marmoute.

looks good

This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.