Page MenuHomePhabricator

merge: move initial handling of mergeactions near to later one
ClosedPublic

Authored by pulkit on Sat, Sep 5, 3:08 AM.

Details

Summary

We build mergeactions in the beginning and use it in end. Let's build it just
before where it will be used. Helps making code much easier to understand.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.Sat, Sep 5, 3:08 AM
marmoute accepted this revision.Fri, Sep 11, 8:56 AM
marmoute added a subscriber: marmoute.

This kind of massive code block move in a huge function make me think we should slice it into smaller function. What do you think?

pulkit updated this revision to Diff 22638.Mon, Sep 14, 7:13 AM
pulkit updated this revision to Diff 22660.Thu, Sep 17, 5:39 AM
indygreg accepted this revision.Thu, Sep 17, 10:10 PM
This revision is now accepted and ready to land.Thu, Sep 17, 10:10 PM