Page MenuHomePhabricator

annotate: mark lines affected by skip-annotate with *
ClosedPublic

Authored by sid0 on Oct 2 2017, 5:35 AM.

Details

Summary

This is to prevent weird surprises from happening with skips being attributed
to the wrong changeset.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

sid0 created this revision.Oct 2 2017, 5:35 AM
indygreg accepted this revision.Oct 2 2017, 6:34 AM
indygreg added a subscriber: indygreg.

This seems reasonable.

Potential follow-ups:

  1. Documentation in help output.
  2. Inline output saying * denotes skip?
  3. Support in templater for indicating skip (maybe test JSON output)?
This revision is now accepted and ready to land.Oct 2 2017, 6:34 AM
sid0 added a comment.Oct 2 2017, 10:51 AM

Yeah, I plan to do all of those before marking the option un-experimental.

sid0 updated this revision to Diff 2330.Oct 2 2017, 11:05 AM
indygreg accepted this revision.Oct 2 2017, 1:15 PM
This revision was automatically updated to reflect the committed changes.