This is an archive of the discontinued Mercurial Phabricator instance.

Differential D897

context: rename local 'attr' to 'attr_'
ClosedPublic

Authored by sid0 on Oct 2 2017, 5:35 AM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHG52e9310626a8: context: rename local 'attr' to 'attr_'
Summary

In the next diff we're going to import mercurial.thirdparty.attr, and pyflakes
complains about this if this rename isn't done.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

sid0 created this revision.Oct 2 2017, 5:35 AM
indygreg accepted this revision.Oct 2 2017, 6:27 AM
indygreg added a subscriber: indygreg.

I could bikeshed the naming. But if there isn't automated style checking to flag it as bad, then it's good.

This revision is now accepted and ready to land.Oct 2 2017, 6:27 AM
Closed by commit rHG52e9310626a8: context: rename local 'attr' to 'attr_' (authored by sid0). · Explain WhyOct 2 2017, 1:23 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 2339

mercurial/context.py

self._datafunc = datafunc self._datafunc = datafunc
self._flags = flags self._flags = flags
self._copied = copied self._copied = copied
if reusable: if reusable:
# copy extra fields from originalfctx # copy extra fields from originalfctx
attrs = ['rawdata', 'rawflags', '_filenode', '_filerev'] attrs = ['rawdata', 'rawflags', '_filenode', '_filerev']
for attr in attrs: for attr_ in attrs:
if util.safehasattr(originalfctx, attr): if util.safehasattr(originalfctx, attr_):
setattr(self, attr, getattr(originalfctx, attr)) setattr(self, attr_, getattr(originalfctx, attr_))
def data(self): def data(self):
return self._datafunc() return self._datafunc()
class metadataonlyctx(committablectx): class metadataonlyctx(committablectx):
"""Like memctx but it's reusing the manifest of different commit. """Like memctx but it's reusing the manifest of different commit.
Intended to be used by lightweight operations that are creating Intended to be used by lightweight operations that are creating
metadata-only changes. metadata-only changes.