( )⚙ D897 context: rename local 'attr' to 'attr_'

This is an archive of the discontinued Mercurial Phabricator instance.

context: rename local 'attr' to 'attr_'

Authored by sid0 on Oct 2 2017, 5:35 AM.



In the next diff we're going to import mercurial.thirdparty.attr, and pyflakes
complains about this if this rename isn't done.

Diff Detail

rHG Mercurial
Lint Skipped
Unit Tests Skipped

Event Timeline

sid0 created this revision.Oct 2 2017, 5:35 AM
indygreg accepted this revision.Oct 2 2017, 6:27 AM
indygreg added a subscriber: indygreg.

I could bikeshed the naming. But if there isn't automated style checking to flag it as bad, then it's good.

This revision is now accepted and ready to land.Oct 2 2017, 6:27 AM
This revision was automatically updated to reflect the committed changes.