This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9062

git: also convert timezone to int (issue6359)
ClosedPublic

Authored by durin42 on Sep 21 2020, 10:23 AM.

Download Raw Diff

Tags

None

Subscribers

mercurial-patches

Details

Reviewers

Group Reviewers

Commits

rHGe7587430ca23: git: also convert timezone to int (issue6359)

Summary

Credit to moshez for testing this in the wild.

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Sep 21 2020, 10:23 AM

Herald added a reviewer: hg-reviewers. · View Herald TranscriptSep 21 2020, 10:23 AM

Herald added a subscriber: mercurial-patches. · View Herald Transcript

sheehan mentioned this in D9068: git: pass `id` attribute of `pygit2.Tree` object.Sep 22 2020, 9:40 AM

sheehan mentioned this in rHG73a5aa5e1857: git: pass `id` attribute of `pygit2.Tree` object.Sep 22 2020, 1:19 PM

indygreg accepted this revision.Sep 22 2020, 10:21 PM

This revision is now accepted and ready to land.Sep 22 2020, 10:21 PM

durin42 added a commit: rHGe7587430ca23: git: also convert timezone to int (issue6359).Sep 22 2020, 10:24 PM

Closed by commit rHGe7587430ca23: git: also convert timezone to int (issue6359) (authored by durin42). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			hgext/git/gitlog.py (2 lines)

Diff 22763

hgext/git/gitlog.py

	parents.append(hp1)			parents.append(hp1)
	if p2 and p2 != nodemod.nullid:			if p2 and p2 != nodemod.nullid:
	parents.append(hp2)			parents.append(hp2)
	assert date is not None			assert date is not None
	timestamp, tz = date			timestamp, tz = date
	sig = pygit2.Signature(			sig = pygit2.Signature(
	encoding.unifromlocal(stringutil.person(user)),			encoding.unifromlocal(stringutil.person(user)),
	encoding.unifromlocal(stringutil.email(user)),			encoding.unifromlocal(stringutil.email(user)),
	timestamp,			int(timestamp),
	-int(tz // 60),			-int(tz // 60),
	)			)
	oid = self.gitrepo.create_commit(			oid = self.gitrepo.create_commit(
	None, sig, sig, desc, gitutil.togitnode(manifest), parents			None, sig, sig, desc, gitutil.togitnode(manifest), parents
	)			)
	# Set up an internal reference to force the commit into the			# Set up an internal reference to force the commit into the
	# changelog. Hypothetically, we could even use this refs/hg/			# changelog. Hypothetically, we could even use this refs/hg/
	# namespace to allow for anonymous heads on git repos, which			# namespace to allow for anonymous heads on git repos, which