This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9083

hg-core: minor code style change (D8958#inline-14993 followup)
ClosedPublic

Authored by acezar on Sep 25 2020, 5:06 AM.

Details

Reviewers
pulkit
Alphare
Group Reviewers
hg-reviewers
Commits
rHG11f3c3f408fd: hg-core: minor code style change (D8958#inline-14993 followup)

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

acezar created this revision.Sep 25 2020, 5:06 AM
pulkit requested changes to this revision.Sep 28 2020, 2:17 AM
pulkit added a subscriber: pulkit.

hg-core: D8958 followup

Seems like that patch is pushed and public now. Hence we cannot amend this into that. Can you update the patch with commit description describing what it's doing? Also, I maybe wrong but it seems like this patch is doing multiple things at once.

This revision now requires changes to proceed.Sep 28 2020, 2:17 AM
acezar retitled this revision from hg-core: D8958 followup to hg-core: minor code style change (D8958#inline-14993 followup).Sep 28 2020, 9:47 AM
acezar added a child revision: D9095: hg-core: Explain offset override of first revision.
acezar updated this revision to Diff 22880.
Alphare accepted this revision.Sep 28 2020, 10:06 AM
pulkit added a comment.Sep 28 2020, 10:40 AM

Need to go through the patches, but thanks a lot for splitting and sending all these individual patches. It will make reviewing a cakewalk.

martinvonz added a subscriber: martinvonz.Sep 29 2020, 1:12 PM
martinvonz added inline comments.
rust/hg-core/src/revlog/index.rs
24

I'll change this to offset + INDEX_ENTRY_SIZE in flight. I hope you don't mind. I find that more natural, and it's what I suggested in the previous, and it matches line 26.

acezar updated this revision to Diff 22920.Sep 29 2020, 1:23 PM
acezar marked an inline comment as done.Sep 29 2020, 1:24 PM
Antoine cezar <acezar@chwitlabs.fr> added a commit: rHG11f3c3f408fd: hg-core: minor code style change (D8958#inline-14993 followup).Sep 29 2020, 1:51 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG11f3c3f408fd: hg-core: minor code style change (D8958#inline-14993 followup) (authored by Antoine cezar <acezar@chwitlabs.fr>). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mrust/hg-core/src/revlog/index.rs (2 lines)

Diff 22920

rust/hg-core/src/revlog/index.rs

impl<'a> Index<'a> { impl<'a> Index<'a> {
/// Create an index from bytes. /// Create an index from bytes.
/// Calculate the start of each entry when is_inline is true. /// Calculate the start of each entry when is_inline is true.
pub fn new(bytes: &'a [u8], is_inline: bool) -> Self { pub fn new(bytes: &'a [u8], is_inline: bool) -> Self {
if is_inline { if is_inline {
let mut offset: usize = 0; let mut offset: usize = 0;
let mut offsets = Vec::new(); let mut offsets = Vec::new();
while (bytes.len() - offset) >= INDEX_ENTRY_SIZE { while offset + INDEX_ENTRY_SIZE <= bytes.len() {
martinvonzUnsubmitted
Done

I'll change this to offset + INDEX_ENTRY_SIZE in flight. I hope you don't mind. I find that more natural, and it's what I suggested in the previous, and it matches line 26.

martinvonz: I'll change this to `offset + INDEX_ENTRY_SIZE` in flight. I hope you don't mind. I find that…
offsets.push(offset); offsets.push(offset);
let end = offset + INDEX_ENTRY_SIZE; let end = offset + INDEX_ENTRY_SIZE;
let entry = IndexEntry { let entry = IndexEntry {
bytes: &bytes[offset..end], bytes: &bytes[offset..end],
offset_override: None, offset_override: None,
}; };
offset += INDEX_ENTRY_SIZE + entry.compressed_len(); offset += INDEX_ENTRY_SIZE + entry.compressed_len();