Page MenuHomePhabricator

tests: add test of copies suggested by Pierre-Yves on D9159
ClosedPublic

Authored by martinvonz on Thu, Oct 8, 11:14 AM.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Thu, Oct 8, 11:14 AM
pulkit accepted this revision.Tue, Oct 13, 3:40 AM
This revision is now accepted and ready to land.Tue, Oct 13, 3:40 AM

This test case should go in tests/test-copies-chain-merge.t since this is where the combination of merging and copies information is tested. It would also ensure that it is properly tested on all the relevant cases. Can we drop it in its current form, and restart review based on a diff on tests/test-copies-chain-merge.t ?

(cc @pulkit )

This test case should go in tests/test-copies-chain-merge.t since this is where the combination of merging and copies information is tested.

That is *one* place where copies and merges are tested, but not the only place. Just search for "merge" in this file if you're curious. There was a very similar case just above the one I added.

It would also ensure that it is properly tested on all the relevant cases.

OTOH, until my next patch in this series, that would mean that it would *not* be tested with copy information in extras.

Can we drop it in its current form, and restart review based on a diff on tests/test-copies-chain-merge.t ?

I don't see any reason to.

This test case should go in tests/test-copies-chain-merge.t since this is where the combination of merging and copies information is tested.

That is *one* place where copies and merges are tested, but not the only place. Just search for "merge" in this file if you're curious. There was a very similar case just above the one I added.

The goal of tests/test-copies-chain-merge.t is to contains an exhaustive testing of copy tracing cases that involves chaining copies+merge. So that tests case must be tested in tests/test-copies-chain-merge.t too.