Page MenuHomePhabricator

copies: make sure deleted copy info do not overwriting unrelated ones
ClosedPublic

Authored by marmoute on Oct 13 2020, 6:40 AM.

Details

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Oct 13 2020, 6:40 AM
marmoute updated this revision to Diff 23232.Oct 15 2020, 5:07 PM
marmoute retitled this revision from copies: test for deleted copy info not overwriting unrelated ones to copies: make sure deleted copy info do not overwriting unrelated ones.Oct 20 2020, 9:54 AM

Gentle ping on this bugfix (cc @pulkit, @martinvonz)

martinvonz accepted this revision.Fri, Oct 30, 1:21 AM
martinvonz added inline comments.
mercurial/copies.py
402–407

new_tt and other_tt are not the best variable names, but that's not this patch's fault. Same thing with the unreadable value[0] and value[1].

tests/test-copies-chain-merge.t
1629–1643

This test case seems pretty redundant with the one in test-copies.t(which was also updated in this patch), but that's not a big deal. (Yes, I get that you test upgrades in this file too.)

This revision is now accepted and ready to land.Fri, Oct 30, 1:21 AM